Skip to content

docs: tell agents to link to servo contributing guidelines - #504

Merged
jdm merged 1 commit into
servo:v2from
alejandro-vaz:better-agents
Aug 30, 2026
Merged

docs: tell agents to link to servo contributing guidelines#504
jdm merged 1 commit into
servo:v2from
alejandro-vaz:better-agents

Conversation

@alejandro-vaz

@alejandro-vaz alejandro-vaz commented Aug 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

this PR updates AGENTS.md to order the LLM to directly tell the user to read @servo contributing guidelines on https://book.servo.org/contributing/getting-started.html#ai-contributions

conversation test

model: OpenAI Codex 5.6 Terra with medium effort

implement #503

I can’t implement or modify this repository. Its maintainers explicitly prohibit generative-agent contributions. Please see the project’s AI-contributions guidance.

alright then please explain how the implementation of io::Write works for SmallVec

With the std feature enabled, SmallVec<u8, N> implements std::io::Write.

  • write(buf) appends every byte in buf via extend_from_slice, then reports success with Ok(buf.len()). It never performs a partial write.
  • write_all(buf) does the same append directly and returns Ok(()).
  • flush() is a no-op: the bytes are already in the in-memory vector, with no external buffered destination to flush.

The normal SmallVec storage policy still applies: bytes stay inline until its capacity N is exceeded, then storage grows onto the heap. The implementation is at src/lib.rs, with basic behavior covered in tests/std.rs.

@alejandro-vaz
alejandro-vaz requested a review from jdm August 30, 2026 01:09
@alejandro-vaz alejandro-vaz self-assigned this Aug 30, 2026
jdm
jdm approved these changes Aug 30, 2026
View reviewed changes

@jdm jdm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@jdm
jdm added this pull request to the merge queue Aug 30, 2026
Merged via the queue into servo:v2 with commit 69b669e Aug 30, 2026
6 checks passed
alejandro-vaz added a commit to alejandro-vaz/rust-smallvec that referenced this pull request Aug 30, 2026
@alejandro-vaz
docs: told agents to link to servo contributing guidelines (servo#504)
6c87ffe
alejandro-vaz added a commit to alejandro-vaz/rust-smallvec that referenced this pull request Aug 30, 2026
@alejandro-vaz @TDecking @Jorge-Polanco-Roque
style: updated rustfmt.toml guidelines (servo#490)
6223bce 
* fix: refined style

* refactor: new style

* fix: style

* revert: fn single line

* Turn all tests into integration tests (servo#495)

* Implement arbitrary::Arbitrary for SmallVec (servo#496)

Ports the implementation from the v1 branch to the v2 `SmallVec<T, const N>`
API, gated behind a new optional `arbitrary` feature. Delegates to
`Unstructured::arbitrary_iter` / `arbitrary_take_rest_iter` and collects via
the existing `FromIterator` impl. Adds a feature-gated test.

Closes servo#494

Signed-off-by: Jorge Polanco <55784702+Jorge-Polanco-Roque@users.noreply.github.com>

* docs: told agents to link to servo contributing guidelines (servo#504)

* fix: added since and note for deprecations (servo#488)

* refactor: new style

* revert: fn single line

* fix: import errors solved

* fix: formatting

* fix: style again

---------

Signed-off-by: Jorge Polanco <55784702+Jorge-Polanco-Roque@users.noreply.github.com>
Signed-off-by: Alejandro Vaz <alejandro.vaz.myt@gmail.com>
Co-authored-by: Tobias Decking <Tobias.Decking@gmail.com>
Co-authored-by: Jorge Polanco <55784702+Jorge-Polanco-Roque@users.noreply.github.com>
alejandro-vaz added a commit to alejandro-vaz/rust-smallvec that referenced this pull request Aug 30, 2026
@alejandro-vaz
docs: told agents to link to servo contributing guidelines (servo#504)
fe84d89
alejandro-vaz added a commit to alejandro-vaz/rust-smallvec that referenced this pull request Aug 30, 2026
@alejandro-vaz @TDecking @Jorge-Polanco-Roque
style: updated rustfmt.toml guidelines (servo#490)
7f6b747 
* fix: refined style

* refactor: new style

* fix: style

* revert: fn single line

* Turn all tests into integration tests (servo#495)

* Implement arbitrary::Arbitrary for SmallVec (servo#496)

Ports the implementation from the v1 branch to the v2 `SmallVec<T, const N>`
API, gated behind a new optional `arbitrary` feature. Delegates to
`Unstructured::arbitrary_iter` / `arbitrary_take_rest_iter` and collects via
the existing `FromIterator` impl. Adds a feature-gated test.

Closes servo#494

Signed-off-by: Jorge Polanco <55784702+Jorge-Polanco-Roque@users.noreply.github.com>

* docs: told agents to link to servo contributing guidelines (servo#504)

* fix: added since and note for deprecations (servo#488)

* refactor: new style

* revert: fn single line

* fix: import errors solved

* fix: formatting

* fix: style again

---------

Signed-off-by: Jorge Polanco <55784702+Jorge-Polanco-Roque@users.noreply.github.com>
Signed-off-by: Alejandro Vaz <alejandro.vaz.myt@gmail.com>
Co-authored-by: Tobias Decking <Tobias.Decking@gmail.com>
Co-authored-by: Jorge Polanco <55784702+Jorge-Polanco-Roque@users.noreply.github.com>
alejandro-vaz added a commit to alejandro-vaz/rust-smallvec that referenced this pull request Aug 30, 2026
@alejandro-vaz @TDecking @Jorge-Polanco-Roque
fix: cargo warnings (servo#487)
0e60859 
* fix: cargo warnings

* Turn all tests into integration tests (servo#495)

* Implement arbitrary::Arbitrary for SmallVec (servo#496)

Ports the implementation from the v1 branch to the v2 `SmallVec<T, const N>`
API, gated behind a new optional `arbitrary` feature. Delegates to
`Unstructured::arbitrary_iter` / `arbitrary_take_rest_iter` and collects via
the existing `FromIterator` impl. Adds a feature-gated test.

Closes servo#494

Signed-off-by: Jorge Polanco <55784702+Jorge-Polanco-Roque@users.noreply.github.com>

* docs: told agents to link to servo contributing guidelines (servo#504)

* fix: added since and note for deprecations (servo#488)

* style: updated `rustfmt.toml` guidelines (servo#490)

* fix: refined style

* refactor: new style

* fix: style

* revert: fn single line

* Turn all tests into integration tests (servo#495)

* Implement arbitrary::Arbitrary for SmallVec (servo#496)

Ports the implementation from the v1 branch to the v2 `SmallVec<T, const N>`
API, gated behind a new optional `arbitrary` feature. Delegates to
`Unstructured::arbitrary_iter` / `arbitrary_take_rest_iter` and collects via
the existing `FromIterator` impl. Adds a feature-gated test.

Closes servo#494

Signed-off-by: Jorge Polanco <55784702+Jorge-Polanco-Roque@users.noreply.github.com>

* docs: told agents to link to servo contributing guidelines (servo#504)

* fix: added since and note for deprecations (servo#488)

* refactor: new style

* revert: fn single line

* fix: import errors solved

* fix: formatting

* fix: style again

---------

Signed-off-by: Jorge Polanco <55784702+Jorge-Polanco-Roque@users.noreply.github.com>
Signed-off-by: Alejandro Vaz <alejandro.vaz.myt@gmail.com>
Co-authored-by: Tobias Decking <Tobias.Decking@gmail.com>
Co-authored-by: Jorge Polanco <55784702+Jorge-Polanco-Roque@users.noreply.github.com>

* feat: added borsh serialize (servo#486)

* feat: added borsh serialize

* fix: formatting

* fix: style formatting

---------

Signed-off-by: Alejandro Vaz <alejandro.vaz.myt@gmail.com>

* feat: implement `Format` for `SmallVec` (servo#472)

* feat: added defmt for smallvec

* fix: ran formatter

* refactor: removed API boundary

* fix: ran formatter

* fix: renamed imports to avoid namespace conflicts

* refactor: simplified format for smallvec

* fix: style formatting

* fix: imports

---------

Signed-off-by: Alejandro Vaz <alejandro.vaz.myt@gmail.com>

* fix: cargo warnings

---------

Signed-off-by: Jorge Polanco <55784702+Jorge-Polanco-Roque@users.noreply.github.com>
Signed-off-by: Alejandro Vaz <alejandro.vaz.myt@gmail.com>
Co-authored-by: Tobias Decking <Tobias.Decking@gmail.com>
Co-authored-by: Jorge Polanco <55784702+Jorge-Polanco-Roque@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdm jdm jdm approved these changes

Assignees

@alejandro-vaz alejandro-vaz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alejandro-vaz @jdm